Skip to content

Cherry-pick #18817 to 7.x: Upgrade k8s.io/client-go and k8s keystore tests#18879

Merged
ChrsMark merged 1 commit intoelastic:7.xfrom
ChrsMark:backport_18817_7.x
Jun 1, 2020
Merged

Cherry-pick #18817 to 7.x: Upgrade k8s.io/client-go and k8s keystore tests#18879
ChrsMark merged 1 commit intoelastic:7.xfrom
ChrsMark:backport_18817_7.x

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Jun 1, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18817 to 7.x branch. Original message:

What does this PR do?

This PR is a follow up for #18096.
Aims to add tests for k8s keystore internal functionality using a fake client for retrieving k8s secrets. An upgrade of k8s.io/client-go is needed in order to make use of the fake client (https://github.com/kubernetes/client-go/releases/tag/v0.18.3, https://pkg.go.dev/k8s.io/client-go@v0.18.3/kubernetes?tab=doc).

Upgrade procedure:

go get k8s.io/client-go@v0.18.3
mage vendor
make notice

Changes:

  1. Upgrade k8s.io/client-go
  2. Add tests for k8s keystore
  3. Improve k8s testing by adding a wait phase until kube-state-metrics in order to avoid flakiness

Why is it important?

In order to cover k8s keystore Retrieve functionality.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 1, 2020
@ChrsMark ChrsMark self-assigned this Jun 1, 2020
@ChrsMark ChrsMark added the Team:Platforms Label for the Integrations - Platforms team label Jun 1, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 1, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 1, 2020
@ChrsMark ChrsMark requested review from a team June 1, 2020 13:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 1, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18879 opened]

  • Start Time: 2020-06-01T13:45:36.298+0000

  • Duration: 78 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 6664
Skipped 1069
Total 7733

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-01T14:18:32.134+0000

    • log

@ChrsMark ChrsMark merged commit eafb541 into elastic:7.x Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrsMark ChrsMark

Labels

backport review Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrsMark @elasticmachine @kaiyan-sheng