Skip to content

Cherry-pick #18769 to 7.8: Guard against empty stream.datasource and namespace#18806

Merged
michalpristas merged 2 commits intoelastic:7.8from
michalpristas:backport_18769_7.8
May 28, 2020
Merged

Cherry-pick #18769 to 7.8: Guard against empty stream.datasource and namespace#18806
michalpristas merged 2 commits intoelastic:7.8from
michalpristas:backport_18769_7.8

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented May 28, 2020

Cherry-pick of PR #18769 to 7.8 branch. Original message:

What does this PR do?

This PR fallbacks to default values if namespace or datasource is an empty string

Why is it important?

Empty string is not a valid value

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas
[Ingest Manager] Guard against empty stream.datasource and namespace (e…
ff5aded 
…lastic#18769)

[Ingest Manager] Guard against empty stream.datasource and namespace (elastic#18769)
@michalpristas michalpristas self-assigned this May 28, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 28, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 28, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 28, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18806 opened]

  • Start Time: 2020-05-28T06:25:09.724+0000

  • Duration: 34 min 7 sec

blakerouse
blakerouse approved these changes May 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit b17a3cf into elastic:7.8 May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels

backport bug Ingest Management:alpha1 Group issues for ingest management alpha1 review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @blakerouse