[libbeat/processors/add_docker_metadata] Adding support for custom cgroup prefixes#16926
Closed
danmx wants to merge 1 commit intoelastic:masterfrom
danmx:master
Closed
[libbeat/processors/add_docker_metadata] Adding support for custom cgroup prefixes#16926danmx wants to merge 1 commit intoelastic:masterfrom danmx:master
danmx wants to merge 1 commit intoelastic:masterfrom
danmx:master
Conversation
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
8 tasks
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
|
jenkins, test this please |
blakerouse
reviewed
Mar 11, 2020
exekias
reviewed
Mar 11, 2020
Contributor
exekias
left a comment
There was a problem hiding this comment.
Thank you so much for contributing 🎉 ! I'm wondering, why do you want to add docker metadata when running on Kubernetes? I would expect users to care more about kubernetes metadata in this case.
This will need a new changelog entry under CHANGELOG.next.asciidoc
Contributor
Author
|
@exekias |
5 tasks
Contributor
Author
|
@exekias I could use this PR to refactor |
Contributor
Author
Signed-off-by: danmx <daniel@iziourov.info>
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ChrsMark
reviewed
May 25, 2020
| // of them are associated with Docker. Docker uses /docker/<CID> and | ||
| // Kubernetes, with Docker as a container runtime, uses | ||
| // /kubepods/<class>/<podID>/<cID> when naming cgroups. | ||
| // We use this to determine the container ID. |
Member
There was a problem hiding this comment.
I think this will not work in cases of having more than one containers for a Pod. For instance, pause containers will be found under /kubepods/<class>/<podID> along with the main containers, and the structure would look like this:
/kubepods/besteffort/pod-abcdef/<cID1>/kubepods/besteffort/pod-abcdef/<cID2>
In this case how we identify which cID we are interested in?
Contributor
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
Hi! We're labeling this issue as |
|
Hi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
This change will allow detection of containers orchestrated by Kubernetes
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Detecting containers running in Kubernetes Cluster
Screenshots
Logs