Skip to content

[Libbeat] Add v7 into libbeat/logp when importing#16764

Merged
kaiyan-sheng merged 1 commit intoelastic:7.xfrom
kaiyan-sheng:fix_logp
Mar 3, 2020
Merged

[Libbeat] Add v7 into libbeat/logp when importing#16764
kaiyan-sheng merged 1 commit intoelastic:7.xfrom
kaiyan-sheng:fix_logp

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 3, 2020

This PR is to fix problem caused by adding version when importing libbeat/logp.

(python-env) kaiyansheng@KaiyanMacBookPro:~/go/src/github.com/elastic/beats/libbeat/processors/actions (fix_logp)$ go vet ./...
# github.com/elastic/beats/v7/libbeat/processors/actions
vet: ./rename_test.go:240:13: cannot use log (variable of type *logp.Logger) as *logp.Logger value in struct literal

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 3, 2020
@blakerouse
Copy link
Copy Markdown
Contributor

blakerouse commented Mar 3, 2020

lgtm!

@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 3, 2020
Closed
@kaiyan-sheng
Copy link
Copy Markdown
Contributor Author

kaiyan-sheng commented Mar 3, 2020

CI is still broken but not related to this fix. Merging this PR.

@kaiyan-sheng kaiyan-sheng merged commit fff389b into elastic:7.x Mar 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_logp branch March 3, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaiyan-sheng @blakerouse