update 7.x test images to 7.7.0 by graphaelli · Pull Request #16699 · elastic/beats

graphaelli · 2020-02-28T22:17:17Z

What does this PR do?

update 7.x tests images to 7.7.0

Why is it important?

7.x tests are using the wrong stack version

Elasticsearch has modified the behaviour on date parsing when the date doesn't include timezone data. Regenerate a couple of golden files that are affected by this change. (cherry picked from commit e61c4c4)

mikemadden42

LGTM

…hots

graphaelli · 2020-03-02T18:01:37Z

test_modules.Test.test_fileset_file_053_system and test_modules.Test.test_fileset_file_059_system are failing on travis, test_modules.Test.test_fileset_file_094_system and test_modules.Test.test_fileset_file_098_system on jenkins - I'm not clear on whether these are transient / known / etc - @mikemadden42 thoughts on how to proceed?

mikemadden42 · 2020-03-02T22:18:29Z

test_modules.Test.test_fileset_file_053_system and test_modules.Test.test_fileset_file_059_system are failing on travis, test_modules.Test.test_fileset_file_094_system and test_modules.Test.test_fileset_file_098_system on jenkins - I'm not clear on whether these are transient / known / etc - @mikemadden42 thoughts on how to proceed?

I have not seen these tests failing. I can look into it.

mikemadden42 · 2020-03-03T14:30:38Z

jenkins retest this please

mikemadden42 · 2020-03-03T16:52:32Z

@graphaelli - I looked into the current Jenkins failures when using your branch, update-7.x-test-snapshots.

make -C filebeat clean check testsuite

I'm seeing this failure when I build locally:

--- FAIL: TestReadConfig2 (0.00s)
--- FAIL: TestMergeConfigFiles (0.00s)
--- FAIL: TestLoadManifestNginx (0.00s)

make -C metricbeat clean check testsuite

I'm seeing this failures when I build locally.

--- FAIL: TestLightModulesAsModuleSource (0.00s)
    --- FAIL: TestLightModulesAsModuleSource/no_registered_modules (0.00s)
        --- FAIL: TestLightModulesAsModuleSource/no_registered_modules/metricsets_for_service (0.00s)
        --- FAIL: TestLightModulesAsModuleSource/no_registered_modules/default_metricsets_for_service (0.00s)
    --- FAIL: TestLightModulesAsModuleSource/same_module_registered_(mixed_modules_case) (0.00s)
        --- FAIL: TestLightModulesAsModuleSource/same_module_registered_(mixed_modules_case)/metricsets_for_service (0.00s)
        --- FAIL: TestLightModulesAsModuleSource/same_module_registered_(mixed_modules_case)/default_metricsets_for_service (0.00s)
    --- FAIL: TestLightModulesAsModuleSource/some_metricsets_registered (0.00s)
        --- FAIL: TestLightModulesAsModuleSource/some_metricsets_registered/metricsets_for_service (0.00s)
        --- FAIL: TestLightModulesAsModuleSource/some_metricsets_registered/default_metricsets_for_service (0.00s)
--- FAIL: TestNewModuleFromConfig (0.01s)
    --- FAIL: TestNewModuleFromConfig/light_module_default_metricset (0.00s)
    --- FAIL: TestNewModuleFromConfig/light_module_override_option (0.00s)
    --- FAIL: TestNewModuleFromConfig/light_module (0.01s)
    --- FAIL: TestNewModuleFromConfig/light_module_with_query (0.00s)
    --- FAIL: TestNewModuleFromConfig/light_module_with_custom_period (0.00s)
    --- FAIL: TestNewModuleFromConfig/mixed_module_with_standard_and_light_metricsets (0.00s)
--- FAIL: TestLightMetricSet_VerifyHostDataURI (0.00s)
--- FAIL: TestLightMetricSet_WithoutHostParser (0.00s)
--- FAIL: TestLightMetricSet_VerifyHostDataURI_NonParsableHost (0.00s)
--- FAIL: TestNewModulesCallModuleFactory (0.00s)
--- FAIL: TestProcessorsForMetricSet_ProcessorsRead (0.00s)
--- FAIL: TestProcessorsForMetricSet_FromSource (0.00s)

Are this also failing locally for you?

mikemadden42 · 2020-03-03T16:56:28Z

@graphaelli - I looked into the current Travis failures when using your branch, update-7.x-test-snapshots. This looks consistent with what we're seeing on Jenkins.

make -C filebeat testsuite

I'm seeing this failure when I build locally:

--- FAIL: TestReadConfig2 (0.00s)
--- FAIL: TestMergeConfigFiles (0.00s)
--- FAIL: TestLoadManifestNginx (0.00s)

graphaelli · 2020-03-03T17:25:35Z

@mikemadden42 would you be able to apply #16175 and see if those still fail? I haven't set up to reproduce locally, I need this change to ensure the next beats sync doesn't revert the same change needed in apm-server.

mikemadden42 · 2020-03-03T20:01:50Z

@graphaelli , I'm still seeing those failures with the changes.

$ grep FAIL: ~/make.log
--- FAIL: TestReadConfig2 (0.00s)
--- FAIL: TestMergeConfigFiles (0.00s)
--- FAIL: TestLoadManifestNginx (0.00s)

$ git diff
diff --git a/filebeat/module/system/auth/test/timestamp.log-expected.json b/filebeat/module/system/auth/test/timestamp.log-expected.json
index 2b881dc5f..0f9022325 100644
--- a/filebeat/module/system/auth/test/timestamp.log-expected.json
+++ b/filebeat/module/system/auth/test/timestamp.log-expected.json
@@ -1,6 +1,6 @@
 [
     {
-        "@timestamp": "2019-06-14T08:40:20.912-02:00",
+        "@timestamp": "2019-06-14T10:40:20.912-02:00",
         "event.dataset": "system.auth",
         "event.module": "system",
         "event.timezone": "-02:00",
@@ -27,4 +27,4 @@
         "process.name": "pam",
         "service.type": "system"
     }
-]
\ No newline at end of file
+]
diff --git a/filebeat/module/system/syslog/test/tz-offset.log-expected.json b/filebeat/module/system/syslog/test/tz-offset.log-expected.json
index 0e9c7d984..9f0a18dee 100644
--- a/filebeat/module/system/syslog/test/tz-offset.log-expected.json
+++ b/filebeat/module/system/syslog/test/tz-offset.log-expected.json
@@ -29,7 +29,7 @@
         "service.type": "system"
     },
     {
-        "@timestamp": "2019-06-14T08:40:20.912-02:00",
+        "@timestamp": "2019-06-14T10:40:20.912-02:00",
         "event.dataset": "system.syslog",
         "event.module": "system",
         "event.timezone": "-02:00",
@@ -42,4 +42,4 @@
         "process.name": "sudo",
         "service.type": "system"
     }
-]
\ No newline at end of file
+]

jsoriano · 2020-03-03T20:37:46Z

Feel free to include the changes of #16175 in this PR so both changes are tested and merged together.

…hots

…e-7.x-test-snapshots

graphaelli · 2020-03-04T22:29:16Z

travis is green, jenkins failures appear to be transient - merging.

jsoriano · 2020-03-05T10:26:45Z

Thanks!

jsoriano and others added 5 commits February 6, 2020 22:29

Regenerate expected files after changes in date parsing (elastic#16139)

d41d0d1

Elasticsearch has modified the behaviour on date parsing when the date doesn't include timezone data. Regenerate a couple of golden files that are affected by this change. (cherry picked from commit e61c4c4)

Merge remote-tracking branch 'origin/7.x' into backport_16139_7.x

0f44381

Merge remote-tracking branch 'origin/7.x' into backport_16139_7.x

ea5c44f

Merge remote-tracking branch 'origin/7.x' into backport_16139_7.x

35cc375

update 7.x tests images to 7.7.0

b5c503b

graphaelli added the enhancement label Feb 28, 2020

graphaelli requested a review from mikemadden42 February 28, 2020 22:17

graphaelli changed the title ~~update 7.x tests images to 7.7.0~~ update 7.x test images to 7.7.0 Feb 28, 2020

graphaelli mentioned this pull request Feb 28, 2020

[7.x] tests/system: fix agent config tests (#3400) elastic/apm-server#3401

Merged

mikemadden42 approved these changes Feb 28, 2020

View reviewed changes

graphaelli added 2 commits March 2, 2020 09:14

Merge remote-tracking branch 'elastic/7.x' into update-7.x-test-snaps…

489ed1d

…hots

Merge remote-tracking branch 'elastic/7.x' into update-7.x-test-snaps…

1e05432

…hots

Merge remote-tracking branch 'origin/7.x' into backport_16139_7.x

6b68c3d

jsoriano mentioned this pull request Mar 3, 2020

Cherry-pick #16139 to 7.x: Regenerate expected files after changes in date parsing #16175

Closed

graphaelli added 2 commits March 4, 2020 14:08

Merge remote-tracking branch 'elastic/7.x' into update-7.x-test-snaps…

91d53fc

…hots

Merge remote-tracking branch 'jsoriano/backport_16139_7.x' into updat…

7e94e91

…e-7.x-test-snapshots

graphaelli requested a review from a team as a code owner March 4, 2020 19:09

graphaelli merged commit f1f2c07 into elastic:7.x Mar 4, 2020

graphaelli deleted the update-7.x-test-snapshots branch March 4, 2020 22:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update 7.x test images to 7.7.0#16699

update 7.x test images to 7.7.0#16699
graphaelli merged 10 commits intoelastic:7.xfrom
graphaelli:update-7.x-test-snapshots

graphaelli commented Feb 28, 2020

Uh oh!

mikemadden42 left a comment

Uh oh!

graphaelli commented Mar 2, 2020 •

edited

Loading

Uh oh!

mikemadden42 commented Mar 2, 2020

Uh oh!

mikemadden42 commented Mar 3, 2020

Uh oh!

mikemadden42 commented Mar 3, 2020 •

edited

Loading

Uh oh!

mikemadden42 commented Mar 3, 2020

Uh oh!

graphaelli commented Mar 3, 2020

Uh oh!

mikemadden42 commented Mar 3, 2020

Uh oh!

jsoriano commented Mar 3, 2020

Uh oh!

graphaelli commented Mar 4, 2020

Uh oh!

jsoriano commented Mar 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

graphaelli commented Feb 28, 2020

What does this PR do?

Why is it important?

Uh oh!

mikemadden42 left a comment

Choose a reason for hiding this comment

Uh oh!

graphaelli commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikemadden42 commented Mar 2, 2020

Uh oh!

mikemadden42 commented Mar 3, 2020

Uh oh!

mikemadden42 commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikemadden42 commented Mar 3, 2020

Uh oh!

graphaelli commented Mar 3, 2020

Uh oh!

mikemadden42 commented Mar 3, 2020

Uh oh!

jsoriano commented Mar 3, 2020

Uh oh!

graphaelli commented Mar 4, 2020

Uh oh!

jsoriano commented Mar 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

graphaelli commented Mar 2, 2020 •

edited

Loading

mikemadden42 commented Mar 3, 2020 •

edited

Loading