Fix the iptables issues#16491
Merged
ph merged 2 commits intoelastic:6.8from Feb 24, 2020
ph:fix/issue-with-testing
Merged
Conversation
The fileset of the iptables test didn't skip the @timestamp field, so I have included the iptables.log data to the list of dataset to remove. I also changed the assertion slighly to be relevant on the order of the expectation and instead of dropping the JSON output in the log we will display the difference as a diff. Fix issues with #15980
Contributor
Author
|
gonna fix.. pep8.. |
urso
approved these changes
Feb 22, 2020
|
CI failure seems to be unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The fileset of the iptables test didn't skip the @timestamp field, so
I have included the iptables.log data to the list of dataset to remove.
I also changed the assertion slighly to be relevant on the order of the
expectation and instead of dropping the JSON output in the log we will
display the difference as a diff.
Fix issues with #15980
I will make another PR to master to add the new assertion which gives you more information about what the error is instead of just dropping the whole JSON object.
Why is it important?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs