Cherry-pick #16199 to 7.x: Upgrade go-ucfg to version 0.8.2#16304
Merged
blakerouse merged 1 commit intoelastic:7.xfrom Feb 13, 2020
Merged
Cherry-pick #16199 to 7.x: Upgrade go-ucfg to version 0.8.2#16304blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse merged 1 commit intoelastic:7.xfrom
Conversation
* Upgrade go-ucfg to master, for testing before 0.8.2 release. * Update notice. * Fix tests. * Update to the v0.8.2 release tag and remake NOTICE.txt. * Improve test name. (cherry picked from commit f9403ce)
ycombinator
approved these changes
Feb 13, 2020
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
LGTM. Thanks for splitting up the backport into two PRs, appreciate it — made the reviews pretty straightforward for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16199 to 7.x branch. Original message:
What does this PR do?
Upgrades go-ucfg to version 0.8.2. (Currently this is pointing to master to get a full test run before releasing go-ucfg at version 0.8.2).
Why is it important?
Includes the following fixes:
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs