Cherry-pick #16128 to 7.x: Improve kubernetes.pod.cpu.usage.limit.pct field description#16192
Merged
ChrsMark merged 1 commit intoelastic:7.xfrom Feb 7, 2020
Merged
Conversation
mtojek
approved these changes
Feb 7, 2020
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Ship it if CI goes green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16128 to 7.x branch. Original message:
What does this PR do?
This PR improves
kubernetes.pod.cpu.usage.limit.pctfield description to make clear how the pct is calculated when at least one container of a Pod has no limits.Why is it important?
When at least one container of a Pod has no limits, the situation can be tricky since in such case the
limit.pctwill fall-back tonode.pct.Example:
In this case the sum of
CoresLimitcalculated atbeats/metricbeat/module/kubernetes/pod/data.go
Line 56 in db51085
will be greater than
nodeCores, causecpu-demo-ctr2has no limit and hence it will addnodeCoresto the sum.Given this fact, later on at
beats/metricbeat/module/kubernetes/pod/data.go
Line 109 in db51085
coresLimitwill become equal tonodeCoresmakingcpu.usage.node.pctandcpu.usage.limit.pctto be equal as well.Related issues
cc @jsoriano @exekias