Cherry-pick #15859 to 7.x: Fix missing support for setting doc…#15914
Merged
urso merged 1 commit intoelastic:7.xfrom Jan 28, 2020
Merged
Cherry-pick #15859 to 7.x: Fix missing support for setting doc…#15914urso merged 1 commit intoelastic:7.xfrom
urso merged 1 commit intoelastic:7.xfrom
Conversation
…tic#15859) * Change to metadata._id Update processors, output, and json parser to store the document ID in `@metadata._id`. This ensures better compatibility with Logstash inputs/filters setting `@metadata._id`. Also add missing `document_id` to decode_json_fields processor, given users the chance to set the document id if the JSON document was embedded in another JSON document. (cherry picked from commit d60b04a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15859 to 7.x branch. Original message:
What does this PR do?
Update processors, output, and json parser to store the document ID in
@metadata._id.Also add missing
document_idto decode_json_fields processor, givenusers the chance to set the document id if the JSON document was
embedded in another JSON document.
Why is it important?
@metadata._id.About the breaking change: The
document_idsetting on the JSON decoder has been introduced in 7.5, but overall effort on supporting event duplication was only finalized in 7.6. This means that the to@metadata._idis a breaking change. But the feature wasn't much documented, while actual documentation on how to configure beats + ES for data duplication is planned for 7.6.Checklist
Author's Checklist
How to test this PR locally
Related issues