Reenable removed tests in test_registrar#15790
Merged
urso merged 1 commit intoelastic:masterfrom Jan 28, 2020
Merged
Conversation
Improvements for detecting file removal have been introduced a while ago. Filebeat doesn't wait until EOF when trying to detect removal. On windows we also introduced some extra API call to detect file-deletion flags being set.
ycombinator
approved these changes
Jan 23, 2020
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
LGTM. I guess we should run CI on this a few times to make sure it's not flaky anymore?
Author
|
Jenkins, test this. |
3 similar comments
Author
|
Jenkins, test this. |
Author
|
Jenkins, test this. |
Author
|
Jenkins, test this. |
Contributor
|
jenkins, test this |
2 tasks
Contributor
|
jenkins, test this |
Author
|
Jenkins, test this. |
Author
|
Merging. The unskipped tests did not fail in any CI run (total 8 runs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unskip flaky filebeat system tests that rely on file removal detection in test_registrar.py
Why is it important?
Improvements for detecting file removal have been introduced a while
ago. Filebeat doesn't wait until EOF when trying to detect removal. On
windows we also introduced some extra API call to detect file-deletion
flags being set.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
Check Filebeat tests did not fail on unskipped tests by rerunning tests a few times on jenkins (only windows tests are affected)
Related issues