Cherry-pick #14839 to 7.x: [Metricbeat] Add STAN (NATS streaming) module#15092
Merged
ChrsMark merged 5 commits intoelastic:7.xfrom Dec 16, 2019
Merged
Cherry-pick #14839 to 7.x: [Metricbeat] Add STAN (NATS streaming) module#15092ChrsMark merged 5 commits intoelastic:7.xfrom
ChrsMark merged 5 commits intoelastic:7.xfrom
Conversation
(cherry picked from commit 10c741a)
mtojek
approved these changes
Dec 13, 2019
Contributor
mtojek
left a comment
There was a problem hiding this comment.
As long as it's only 7.x backport, feel free to merge it :)
mtojek
suggested changes
Dec 13, 2019
Contributor
mtojek
left a comment
There was a problem hiding this comment.
I'm afraid you will need to run also mage fmt update (see Travis output).
Contributor
|
Travis error is from time-outs now in heartbeat and the metricbeat test suites due to the test stdout being swallowed. Simple fix for the 7.x doc change otherwise. |
Member
Author
|
I restarted the failed jobs. We need to solve the conflict in Changelog. I propose we remove completely the docs link to avoid these issues. Wdyt? |
mtojek
approved these changes
Dec 13, 2019
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Member
Author
What I said about removing docs is not correct. These files are auto generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #14839 to 7.x branch. Original message:
This PR cherry-picks the commits of @devon-kim
from 7.2...devon-kim:ops-1844-stan-metricbeat so as to be merged to
beats/masteras part of #14629.cc: @exekias
Manual testing
docker build -t stan_test .(run this command underx-pack/metricbeat/module/stan/_meta)docker run -p 8222:8222 stan_test(Note that default fetching period is 60secs, so this might should be changed for the testing)