Skip to content

Cherry-pick #15011 to 7.x: Registered metricsets fail to load if listed as light modules#15061

Merged
mtojek merged 1 commit intoelastic:7.xfrom
mtojek:backport_14698_7.x
Dec 12, 2019
Merged

Cherry-pick #15011 to 7.x: Registered metricsets fail to load if listed as light modules#15061
mtojek merged 1 commit intoelastic:7.xfrom
mtojek:backport_14698_7.x

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Dec 11, 2019

Issue: #14698

This PR adjusts current behavior of the metricbeat which fails initialization of mixed modules while loading standard and light metricsets.

Added two test cases.

Original PR: #15011

…csets (elastic#15011)

* Prepare test case for mixed module

* Ignore registered modules while loading light metricsets

* Test case: fail on unregistered module

* Fix: mage fmt

* Fix: replace String with ...Info

* Rename method to ModulesInfo()

(cherry picked from commit 1769f67)
@mtojek mtojek requested a review from a team December 11, 2019 16:56
@mtojek mtojek self-assigned this Dec 11, 2019
@exekias
Copy link
Copy Markdown
Contributor

exekias commented Dec 12, 2019

Just saw this doesn't have a changelog, nor the original PR (please link it in the description if you are not using the backport tool)

@mtojek mtojek changed the title Cherry-pick #14698 to 7.x: Registered metricsets fail to load if listed as light modules Cherry-pick #15011 to 7.x: Registered metricsets fail to load if listed as light modules Dec 12, 2019
@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Dec 12, 2019

Done, linked.

@mtojek mtojek merged commit 39c55a9 into elastic:7.x Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants