Skip to content

Use dashes instead of spaces in UA#14748

Merged
andrewvc merged 4 commits intoelastic:masterfrom
andrewvc:remove-ua-space
Dec 2, 2019
Merged

Use dashes instead of spaces in UA#14748
andrewvc merged 4 commits intoelastic:masterfrom
andrewvc:remove-ua-space

Conversation

@andrewvc
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc commented Nov 25, 2019

HTTP user agents should not have spaces unless intentionally used as a separator.

This should not be backported to 7.x since it's a breaking change for filebeat. A variant targeting only heartbeat should be backported since that is yet unreleased.

Fixes #14747

@andrewvc andrewvc self-assigned this Nov 25, 2019
@andrewvc andrewvc added Team:obs-ds-hosted-services Label for the Observability Hosted Services team bug Filebeat Filebeat Heartbeat labels Nov 25, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (:uptime)

@andrewvc andrewvc requested a review from ruflin November 26, 2019 20:47
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit 376eb7c into elastic:master Dec 2, 2019
@andrewvc andrewvc deleted the remove-ua-space branch December 2, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Filebeat Filebeat Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beats HTTP user agent does not follow RFC

3 participants