[6.8] Check if file has disappeared sooner in Log reader (#13907)#13960
[6.8] Check if file has disappeared sooner in Log reader (#13907)#13960ycombinator merged 7 commits intoelastic:6.8from ycombinator:backport/6.8/pr-13907
Conversation
urso
left a comment
There was a problem hiding this comment.
Please check CI. Looks like you are using functions that have been changed/introduced in 7.x
|
jenkins, test this |
|
@urso The CI failure is now fixed so this is ready for another review from you, when you get a chance, please. Thanks! |
|
jenkins, test this |
filebeat/input/log/file.go
Outdated
There was a problem hiding this comment.
exported method File.Removed should have comment or be unexported
filebeat/input/log/file.go
Outdated
There was a problem hiding this comment.
exported method File.Removed should have comment or be unexported
filebeat/input/log/stdin.go
Outdated
There was a problem hiding this comment.
exported method Pipe.Removed should have comment or be unexported
filebeat/input/log/file.go
Outdated
There was a problem hiding this comment.
exported method File.Removed should have comment or be unexported
* Adding comment about EOF and removing redundant logic * Adding debug logging when close_remove and close_renamed situations are reached * Check file stats related errors before adding to buffer * Reordering checks to be same as before * Add CHANGELOG entry * Fixing issue # in CHANGELOG entry * Move CloseInactive and truncate checks back to being after EOF check * Don't perform stat call for CloseRemoved/CloseRenamed unless those settings are enabled * Better comments / function godoc * Renaming method to be more descriptive * Fixing up CHANGELOG
|
Travis CI is green but Jenkins CI is not. However, the only build that are failing in Jenkins CI is X-Pack/Metricbeat on Linux. The 6.8 X-Pack/Metricbeat on Linux build hasn't been green for as long as we have history for that build: https://beats-ci.elastic.co/job/elastic+beats+6.8+multijob-linux/beat=x-pack%2Fmetricbeat,label=linux-immutable/. Since this failure is unrelated to this PR, I'm going ahead and merging it now. |
Backports the following commits to 6.8: