[metricbeat] Migrate prometheus/collector to reporterv2 with error#13521
Merged
fearful-symmetry merged 3 commits intoelastic:masterfrom Sep 10, 2019
Merged
Conversation
Contributor
Author
|
Jenkins, test this |
93 tasks
5ec0daa to
9608565
Compare
Contributor
Author
|
Okay, I still can't get CI to go green, so I'm wondering if I broke something. |
odacremolbap
approved these changes
Sep 7, 2019
9608565 to
d6f6f65
Compare
Contributor
Author
|
Okay, thing I figured out what's going on. |
jsoriano
reviewed
Sep 9, 2019
x-pack/metricbeat/module/cockroachdb/status/status_integration_test.go
Outdated
Show resolved
Hide resolved
jsoriano
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11374
Considering how big and important a lot of the core Prometheus stuff, I'm surprised this is such a small PR.