[metricbeat] Migrate nginx/substatus to reporterv2 with error#13518
Merged
fearful-symmetry merged 2 commits intoelastic:masterfrom Sep 6, 2019
Merged
Conversation
93 tasks
jsoriano
approved these changes
Sep 5, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
It LGTM, added a small suggestion.
| service := compose.EnsureUp(t, "nginx") | ||
|
|
||
| f := mbtest.NewReportingMetricSetV2(t, getConfig(service.Host())) | ||
| if err := mbtest.WriteEventsReporterV2(f, t, ""); err != nil { |
Member
There was a problem hiding this comment.
Or even better 🙂
f := mbtest.NewFetcher(t, getConfig(service.Host()))
f.WriteEvents(t, "")
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
I don't think the CI failures I'm seeing are related. |
Contributor
Author
|
jenkins, test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11374
There was a community PR for this, but it's been abandoned so I'm just doing it myself. This one is a bit odd, since it requires changes to some other metricbeat tests, which will look for error strings.