[metricbeat]kubernetes cronjob through kube-state-metrics#13001
Merged
odacremolbap merged 14 commits intoelastic:masterfrom Aug 8, 2019
Merged
[metricbeat]kubernetes cronjob through kube-state-metrics#13001odacremolbap merged 14 commits intoelastic:masterfrom
odacremolbap merged 14 commits intoelastic:masterfrom
Conversation
houndci-bot
reviewed
Jul 22, 2019
Contributor
Author
|
jenkins test this |
sayden
approved these changes
Aug 5, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
Overall looks awesome! Well done! I left some comment
jsoriano
reviewed
Aug 5, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
This is looking good, just one thing.
Contributor
|
After the change of namespace mentioned by @jsoriano everything looks good :) |
jsoriano
approved these changes
Aug 6, 2019
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
jenkins, test this |
Member
|
Failures in CI doesn't seem related, I think this is good to go. |
Contributor
Author
|
jenkins, test this |
1 similar comment
Contributor
Author
|
jenkins, test this |
Contributor
|
Hey @odacremolbap , nice work on the PR! Any plans on adding a dashboard for this metricset? |
Contributor
Author
|
there is no kubernetes dashboard for the kube-state-metrics objects, I think they are somehow included in the kibana > infrastructure > kubernetes, but I haven't been exposed to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add kubernetes cronjob metrics using
kube-state-metricsCronjob metrics as informed by
kube-state-metricsPod information is not retrieved using these metrics.
Enricher is not used