Adapt Kibana interface for external usage#12266
Merged
jalvz merged 2 commits intoelastic:masterfrom May 24, 2019
Merged
Conversation
houndci-bot
reviewed
May 24, 2019
|
|
||
| retError = extractError(result) | ||
| return resp.StatusCode, result, retError | ||
| func (conn *Connection) RoundTrip(r *http.Request) (*http.Response, error) { |
There was a problem hiding this comment.
exported method Connection.RoundTrip should have comment or be unexported
| return resp.StatusCode, result, retError | ||
| } | ||
|
|
||
| func (conn *Connection) Send(method, extraPath string, |
There was a problem hiding this comment.
exported method Connection.Send should have comment or be unexported
kvch
reviewed
May 24, 2019
|
|
||
| resp, err := conn.Send(method, extraPath, params, headers, body) | ||
| if err != nil { | ||
| return 0, nil, fmt.Errorf("fail to execute the HTTP %s request: %v", method, err) |
Contributor
There was a problem hiding this comment.
Please use "%+v" instead of "%v".
kvch
approved these changes
May 24, 2019
Contributor
kvch
left a comment
There was a problem hiding this comment.
Left one minor comment. Otherwise 👍
houndci-bot
reviewed
May 24, 2019
|
|
||
| retError = extractError(result) | ||
| return resp.StatusCode, result, retError | ||
| // Implements RoundTrip interface |
There was a problem hiding this comment.
comment on exported method Connection.RoundTrip should be of the form "RoundTrip ..."
| return resp.StatusCode, result, retError | ||
| } | ||
|
|
||
| // Sends an application/json request to Kibana with appropriate kbn headers |
There was a problem hiding this comment.
comment on exported method Connection.Send should be of the form "Send ..."
Contributor
Author
|
Thank you! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kbn-xsrfheader (security).RoundTripinterface: facilitates testing outside the package, where there is no access toconn.httpSendRequestin 2 methods, so external callers not interested in theextractErrorfunctionality can get the bare*Responseobject.