[Filebeat] Enabled convert_timezone in tests by default in tests#12123
Merged
ruflin merged 2 commits intoelastic:masterfrom May 21, 2019
Merged
[Filebeat] Enabled convert_timezone in tests by default in tests#12123ruflin merged 2 commits intoelastic:masterfrom
ruflin merged 2 commits intoelastic:masterfrom
Conversation
98e7b00 to
8fd4ebc
Compare
In elastic#12120 a default timezone (UTC) is introduced for the tests. This allows us to enabled `convert_timezone` in all tests. It guarantees that we also test the data conversion part in the pipelines. No timestamps changed because they were already assumed in UTC when no timezone is set.
8fd4ebc to
f8b2995
Compare
jsoriano
approved these changes
May 21, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
I would even enable it in all filesets 😄
Contributor
Author
|
@jsoriano Not sure I get your comment. You mean changing the default? |
Member
|
@ruflin yes, I was only giving a +1 to changing this option so all modules convert timezones by default. But this is something to think better in a future PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #12120 a default timezone (UTC) is introduced for the tests. This allows us to enabled
convert_timezonein all tests. It guarantees that we also test the data conversion part in the pipelines.No timestamps changed because they were already assumed in UTC when no timezone is set.