[Auditbeat] Cherry-pick #12028 to 6.8: Login: Fix re-read of utmp files#12108
Merged
cwurm merged 1 commit intoelastic:6.8from May 15, 2019
Merged
[Auditbeat] Cherry-pick #12028 to 6.8: Login: Fix re-read of utmp files#12108cwurm merged 1 commit intoelastic:6.8from
cwurm merged 1 commit intoelastic:6.8from
Conversation
Contributor
|
Pinging @elastic/secops |
The `login` dataset is not using the previous file offset when reading new entries in a utmp file. As a result, whenever a new login event occurs, all records are re-read. Also expands the documentation, moves test files to testdata/, and adds a test case that adds a utmp record to the test file and re-reads it to make sure this bug does not happen again. (cherry picked from commit 683f4f7)
adriansr
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12028 to 6.8 branch. Original message:
The
logindataset is not using the previous file offset when reading new entries in a utmp file. As a result, whenever a new login event occurs, all records are re-read.The fix for this is one line in utmp.go (
utmpFile.Offset = savedUtmpFile.Offset).I also took the opportunity to expand the documentation, move our test files to
testdata/, and write a test case that adds a utmp record to the test file and re-reads it to make sure this bug does not happen again.