Check goroutines in places related to recent found leaks#12106
Merged
jsoriano merged 20 commits intoelastic:masterfrom May 24, 2019
Merged
Check goroutines in places related to recent found leaks#12106jsoriano merged 20 commits intoelastic:masterfrom
jsoriano merged 20 commits intoelastic:masterfrom
Conversation
jsoriano
commented
May 8, 2019
andrewkroh
reviewed
May 8, 2019
Member
andrewkroh
left a comment
There was a problem hiding this comment.
Do our runtime metrics that get logged every 30s include a gauge for the number of goroutines? That would be helpful for identifying if a leak is introduced to a Beat.
Member
Author
|
I am moving the fix for the leak in |
Member
Author
Created PR for that #12135 |
This was referenced May 9, 2019
houndci-bot
reviewed
May 10, 2019
houndci-bot
reviewed
May 10, 2019
houndci-bot
reviewed
May 10, 2019
b8c4367 to
1b42a6b
Compare
jsoriano
commented
May 10, 2019
Member
Author
|
Failing tests caused by #12171 |
ca0e54f to
34c627a
Compare
This was referenced May 20, 2019
Merged
Merged
Merged
575e14c to
02eeabb
Compare
Member
Author
|
@exekias @andrewkroh this would be ready for review, thanks! |
Member
Author
|
Test failure in Windows looks related, I'll look at this |
andrewkroh
approved these changes
May 23, 2019
| time.Sleep(10 * time.Millisecond) | ||
| } | ||
| profile := pprof.Lookup("goroutine") | ||
| profile.WriteTo(os.Stdout, 2) |
exekias
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the strategy used in #10850 to check for goroutine leaks
on tests in some places related to the leaks investigated as part
of #9302.
Several things here:
goroutines dump on failure.
CloseOnSignalandSubOutlettests (they detect the issues solved by Stop waiting for signals on closed outleters #11263)
by Fix goroutine leak on initialization failures of log input #12125 and Fix goroutine leak on non-explicit finalization of log inputs #12164)