Add helper with a common interface for all test reporters#11998
Merged
jsoriano merged 7 commits intoelastic:masterfrom Jul 15, 2019
Merged
Add helper with a common interface for all test reporters#11998jsoriano merged 7 commits intoelastic:masterfrom
jsoriano merged 7 commits intoelastic:masterfrom
Conversation
Every time we add a new interface, or we change the interface implemented by a module we have to rewrite also the affected tests. We have helpers for all interfaces we implement, take advantage of these helpers to create a single helper that implements the basic operations needed in integration tests, so all integration tests can use the same methods, with independence of the interface implemented by the metricset.
houndci-bot
reviewed
Apr 30, 2019
houndci-bot
reviewed
Jul 2, 2019
houndci-bot
reviewed
Jul 2, 2019
houndci-bot
reviewed
Jul 2, 2019
Member
Author
|
Opening this for review. It'd be nice to support also pushers, but there is not such an advantage as it wouldn't be so common to migrate from fetcher to pusher or the other way around. It'd be nice in any case to have a common interface for pushers, I leave this for a future change. |
exekias
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time we add a new interface, or we change the interface
implemented by a module we have to rewrite also the affected tests.
We have helpers for all interfaces we implement, take advantage of
these helpers to create a single helper that implements the basic
operations needed in integration tests, so all integration tests can
use the same methods, with independence of the interface implemented
by the metricset.