[Metricbeat] Migrate NATS to reporterv2 with error handling#11881
Merged
fearful-symmetry merged 2 commits intoelastic:masterfrom Apr 23, 2019
Merged
Conversation
| return err | ||
| return errors.Wrap(err, "failure applying module schema") | ||
| } | ||
| r.Event(event) |
Contributor
There was a problem hiding this comment.
Should we add the check here for report.Event? If you want to open a separate PR for that, I guess that's fine too 😄
Contributor
There was a problem hiding this comment.
I don't think it is needed? this metricset will report a single event on every fetch, so there is no need to check for stop in case of stop
exekias
reviewed
Apr 23, 2019
Contributor
exekias
left a comment
There was a problem hiding this comment.
LGTM, left a minor comment
| err = errors.Wrap(err, "failure parsing Nats connections API response") | ||
| r.Error(err) | ||
| return err | ||
| return errors.Wrap(err, "failure parsing Nats connections API response") |
Contributor
There was a problem hiding this comment.
I know this was there already, but it should say NATS
| return err | ||
| return errors.Wrap(err, "failure applying module schema") | ||
| } | ||
| r.Event(event) |
Contributor
There was a problem hiding this comment.
I don't think it is needed? this metricset will report a single event on every fetch, so there is no need to check for stop in case of stop
Contributor
Author
|
Alright @exekias I updated that, since it kinda bugged me as well. |
93 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #11374