[metricbeat] migrate kvm to ReporterV2 with new error handling #11814
Merged
fearful-symmetry merged 4 commits intoelastic:masterfrom Apr 15, 2019
Merged
Conversation
exekias
reviewed
Apr 15, 2019
| }, | ||
| }) | ||
| if !reported { | ||
| break |
Contributor
There was a problem hiding this comment.
this will go to the next domain, you probably want to return here?
Contributor
Author
There was a problem hiding this comment.
Ah yah, think you're right.
| report.Error(errors.Wrap(err, "failed to disconnect")) | ||
| msg := errors.Wrap(err, "failed to disconnect") | ||
| report.Error(msg) | ||
| m.Logger().Error(msg) |
Contributor
There was a problem hiding this comment.
sorry I missed previous discussions and refactor. Was report.Error logging this message before?
Contributor
Author
There was a problem hiding this comment.
@ruflin 's thinking was that report-ed error messages and logged error messages get sent to different places & are consumed in different ways, so we should sent errors to both.
Contributor
There was a problem hiding this comment.
Thanks for explaining, LGTM
93 tasks
exekias
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #11374
A few changes here, adding a break statement to the loop and so on.