[Metricbeat] Remove EventFetcher and EventsFetcher interface#11762
[Metricbeat] Remove EventFetcher and EventsFetcher interface#11762ruflin wants to merge 2 commits intoelastic:masterfrom
Conversation
After migrating all metricsets (elastic#10774) to the Reporter interfaces, the EventFetcher and EventsFetcher interface can be removed.
|
what would happen to existing community beats that upgrade |
|
@exekias They will break and have to migrate to the new reporter. But in most cases this should be pretty straight forward and I don't think we should wait until 8 to remove this. |
|
@exekias Assigning this to you for now, hope that is ok. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
I don't think this happened in the end, IIRC there were a few bits still pending in the PR |
|
Should I best close this PR so someone can follow up with this? |
|
I'd love to remove that much code (when working on collector POC these interfaces did contribute to most complexity/code...). If there is something pending lets close and create an issue, otherwise get rid of it now. |
|
@urso ++. Can someone from the team take this over? |
|
Not sure what is missing + I would like someone who is familiar with metricset implementation to change these kind of internals. @jsoriano Can you have a look? |
|
Hi, yes, I will take a look 👍 |
|
Continuing with this in #25093. |
After migrating all metricsets (#10774) to the Reporter interfaces, the EventFetcher and EventsFetcher interface can be removed.