Migrate golang/expvar to ReporterV2#11103
Merged
fearful-symmetry merged 2 commits intoelastic:masterfrom Mar 6, 2019
Merged
Conversation
Contributor
Author
|
Goreturn or something else decided to add |
Contributor
Author
|
Travis failures are all due to apt-get, which is...unexpected. |
sayden
approved these changes
Mar 5, 2019
62 tasks
Contributor
|
jenkins, test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10774
This was a little more involved, as the ReporterV2 interface does namespaces differently. It appears that the resulting data structures are the same, so all should be well.