[Metricbeat] Add http endpoint tests for php_fpm module#11088
Merged
ruflin merged 1 commit intoelastic:masterfrom Mar 6, 2019
Merged
[Metricbeat] Add http endpoint tests for php_fpm module#11088ruflin merged 1 commit intoelastic:masterfrom
ruflin merged 1 commit intoelastic:masterfrom
Conversation
This adds also support for query params to the testing framework.
sayden
reviewed
Mar 5, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
While I see that "endpoint tests for php_fpm module" have been added, I don't understand why the TestData functions have been removed. I don't think it's an error but maybe you can update the PR description so we can give you a better review 🙂
Contributor
Author
|
This change is based on #10648 The data.json files are now generated on each test run and should stay the same (like in Filebeat). The dynamic generation is not needed anymore. Updated also the PR description. |
sayden
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on #10648 to migrate to golden files instead of the dynamically generated data files.
This adds also support for query params to the testing framework.