[Metricbeat] Migrate heap to reporterV2 interface #11074
Merged
fearful-symmetry merged 3 commits intoelastic:masterfrom Mar 5, 2019
Merged
[Metricbeat] Migrate heap to reporterV2 interface #11074fearful-symmetry merged 3 commits intoelastic:masterfrom
fearful-symmetry merged 3 commits intoelastic:masterfrom
Conversation
kaiyan-sheng
reviewed
Mar 4, 2019
62 tasks
Contributor
|
jenkins, test this |
sayden
approved these changes
Mar 5, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
LGTM. Let's wait to for the blessings of Jenkins
kaiyan-sheng
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10774
My first PR here! Feel free to tell me if I did anything egregious.
It looks like there's no 'standard' way for different metricsets to use their own
eventMapping()so I just stuck to things I saw others doing. It looks like the golang module was one of the few that didn't have a dedicateddata.gofor processing, so I did that as well.I'd also like to add a unit test to
eventMapping()here, since it has a fair bit of logic and that's just something I would normally do, but I think that should be its own PR.