[Metricbeat] Migrate Ceph osd_tree to use ReporterV2 interface#11048
[Metricbeat] Migrate Ceph osd_tree to use ReporterV2 interface#11048sayden merged 2 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins, test this please |
sayden
left a comment
There was a problem hiding this comment.
Overall looks good, just one single change is needed to merge PR. Everything else in comments are minor.
There was a problem hiding this comment.
If you rebase to master, you can remove this line
There was a problem hiding this comment.
If you rebase to master, you can use m.Logger().Error(err) here instead
There was a problem hiding this comment.
If you rebase to master, you can use m.Logger().Error(err) here instead
There was a problem hiding this comment.
Again, this is the only critical change needed here. Check my comments here to avoid a flaky test
388b053 to
65c4dbb
Compare
|
Thanks for your review. I believe I've addressed all the feedback now. |
|
jenkins, test this |
Refer to #10774 for more info