[Metricbeat] Migrate Couchbase bucket to use ReporterV2 interface#11045
Merged
sayden merged 1 commit intoelastic:masterfrom Mar 7, 2019
Merged
Conversation
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
jenkins, test this please |
62 tasks
sayden
suggested changes
Mar 7, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
Overall looks good. Good work! Just one small change
| t.Logf("%s/%s event: %+v", f.Module().Name(), f.Name(), events[0]) | ||
| } | ||
|
|
||
| func TestData(t *testing.T) { |
Contributor
There was a problem hiding this comment.
As commented in other PR's, to avoid potential flaky tests TestData must now look like this:
func TestData(t *testing.T) {
f := mbtest.NewReportingMetricSetV2(t, getConfig())
if err := mbtest.WriteEventsReporterV2(f, t, ""); err != nil {
t.Fatal("write", err)
}
}
Contributor
|
Changed my mind, it's enough with this, we can do a follow up PR, this module doesn't fails 😄 Thanks @berfinsari ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #10774 for more info