[Metricbeat] Migrate Apache status Metricset to use ReporterV2 interface#10986
[Metricbeat] Migrate Apache status Metricset to use ReporterV2 interface#10986sayden merged 13 commits intoelastic:masterfrom
Conversation
|
jenkins, test this |
f65ea9b to
3767fa5
Compare
|
Error in Elasticsearch module seems unrelated https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/beat=metricbeat,label=linux-immutable/5506/console |
There was a problem hiding this comment.
apache has a timeout of more then 10s?
There was a problem hiding this comment.
I can't remember why I changed this, frakly. I know there was a good reason 😕 Default is 10 seconds and I raised to 20 because I probably received some timeout in some moment. If you want I can leave it in 10 again until I remember 😅
There was a problem hiding this comment.
I prefer to go back to 10s as long as we don't know why.
|
Same as other PR's, set it to |
3767fa5 to
9c9a5ef
Compare
|
@ruflin I tried to use the new testing framework here but I was getting a 404. I'm not sure about why so I uploaded everything I had progressed. |
|
@sayden Will have a look. |
There was a problem hiding this comment.
This needs to be url: "/server-status?auto=" as it uses a param.
There was a problem hiding this comment.
This should look identical to https://github.com/elastic/beats/blob/master/metricbeat/module/apache/status/_meta/test/status_apache-2.4.23-CentOS6 and the others. You missed probably the ?auto part in your query.
There was a problem hiding this comment.
I prefer to go back to 10s as long as we don't know why.
1ced142 to
23ba063
Compare
23ba063 to
99ca5e6
Compare
ruflin
left a comment
There was a problem hiding this comment.
LGTM. We should remove the TestData either in this PR or a follow up.
I think quite a few of the status_test tests will also get obsolete with the change to the new testing framework. We should add apache tests files from different versions.
Ready to be merged, all the above can be done in follow up PR's. CI failure is not related.
| } | ||
| } | ||
|
|
||
| func TestData(t *testing.T) { |
There was a problem hiding this comment.
We can remove this one, right?
Refer to #10774 for more info