[Metricbeat] Migrate Kubernetes state_pod Metricset to use ReporterV2 interface#10973
Conversation
|
jenkins, test this |
|
Error in ES module seem unrelated https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/beat=metricbeat,label=linux-immutable/5455/console |
1e4bb79 to
0958d7b
Compare
|
After last push, error is related. Checking |
|
I'm not sure if |
jsoriano
left a comment
There was a problem hiding this comment.
I have added some comments, I hope they help.
There was a problem hiding this comment.
What are these _module objects? I think they shouldn't be here.
There was a problem hiding this comment.
Kubernetes namespace should be in kubernetes.namespace.
There was a problem hiding this comment.
Is this the same file as the one in metricbeat/module/kubernetes/_meta/test/?
Could we also add metricbeat/module/kubernetes/_meta/test/kube-state-metrics to this testdata? If we can I think we could remove state_pod_test.go as you suggested.
There was a problem hiding this comment.
Kubernetes node name should be in kubernetes.node.name.
There was a problem hiding this comment.
You should use RootFields for common fields as kubernetes.namespace or kubernetes.pod.name.
1e4a603 to
268a8af
Compare
268a8af to
0ee4524
Compare
Refer to #10774 for more info