[Metricbeat] Migrate Kubernetes state_node Metricset to use ReporterV2 interface#10962
Conversation
|
jenkins, test this |
|
jenkins, test this again please |
5caf770 to
9f3daa6
Compare
|
Error in RabbitMQ seems unrelated https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/beat=metricbeat,label=linux-immutable/5499/console |
|
jenkins, test this |
ruflin
left a comment
There was a problem hiding this comment.
I'm good with merging this as is.
Overall it looks like a prime candidate for the new http test framework. I can take a stab at it as soon as this is merged.
There was a problem hiding this comment.
I would assume with v2 no _namespace field should be needed anymore?
There was a problem hiding this comment.
I checked the code and it seems for prometheus modules namespace is used a bit different then I expected.
There was a problem hiding this comment.
I checked the code and it seems for prometheus modules namespace is used a bit different then I expected.
There was a problem hiding this comment.
If we just add the event to the MetricSetFields here I think it will be reported under kubernetes.state_node but looking at the existing data.json it's under kubernetes.node:
"kubernetes": {
"node": {
"cpu": {
"allocatable": {
"cores": 2
},
We need to respect the namespace.
@sayden Can you verify that?
There was a problem hiding this comment.
Isn't the namespace for this metricset always node?
Should be the same value as mapping.ExtraFields[mb.NamespaceKey]
d277ee1 to
3c4a590
Compare
Refer to #10774 for more info