Don't expect aliases in output dictionaries#10921
Merged
jsoriano merged 4 commits intoelastic:masterfrom Feb 28, 2019
Merged
Conversation
91ecca1 to
e907907
Compare
Member
Author
|
Failing tests will pass once #10927 is merged, will rebase then. |
sayden
approved these changes
Feb 27, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
Code seems ok although I'm not really sure about how to test it
Member
Author
|
@sayden you can test it by writing from a module to a field documented as alias, and running the system tests for this module. For example if you revert #10927 and run I can wait to merge this if you want to give it a try. |
Contributor
|
I don't want to block this PR. Just wanted to give you some help trying a local test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the creation of aliases for ECS we have found that some features
weren't being migrated and were writing to aliases (like in #10757).
Consider writing to an alias field like writing to an undocumented field.