[Metricbeat] Migrate Kubernetes container Metricset to use ReporterV2 interface#10855
Merged
sayden merged 2 commits intoelastic:masterfrom Feb 26, 2019
Merged
Conversation
62 tasks
kaiyan-sheng
approved these changes
Feb 21, 2019
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
I was working on migrating k8s to ecs. That PR should probably wait till this one gets in :-)
| events, err := eventMapping(body, util.PerfMetrics) | ||
| if err != nil { | ||
| return nil, err | ||
| logger.Error(err) |
Contributor
There was a problem hiding this comment.
should we add a err= errors.wrap(err, "eventMapping failed") here to give more content?
Contributor
Author
There was a problem hiding this comment.
Good question. I'm not sure about it because I usually like to print errors that are relevant for the users (not for us) to help them fix their config issues or similar things.
But I'm also sure that I'm not probably consistent about this 😄
kaiyan-sheng
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #10774 for more info