Cover empty request data, url and version in Apache2 Filebeat module#10730
Merged
sayden merged 4 commits intoelastic:masterfrom Feb 15, 2019
Merged
Cover empty request data, url and version in Apache2 Filebeat module#10730sayden merged 4 commits intoelastic:masterfrom
sayden merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
@sayden looks like all the timestamp is ignoring the timezone information now hmmm |
Contributor
Author
|
jenkins, test this please |
kaiyan-sheng
approved these changes
Feb 14, 2019
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Timestamp looks good now!
Contributor
Author
|
jenkins, test this please |
jsoriano
approved these changes
Feb 14, 2019
This was referenced Feb 18, 2019
Member
|
It seems it was already backported, I am removing the needs_backport label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue #10656 we weren't parsing properly HTTP timeouts where HTTP information from the server isn't received (url, request method and version).
The example line from the issue is included and a slight modification to the existing Grok patterns covers this use case.
Please, take a closer look at this file https://github.com/elastic/beats/compare/master...sayden:bugfix/fb/parse-empty-data-in-apache?expand=1#diff-9c8ecada761029001c82a19f1f2edafe because, for some reason I don't fully understand, the timezone of the "old" lines has changed when regenerating the file.