Skip to content

Suricata: Rename event.type to suricata.eve.event_type#10575

Merged
adriansr merged 4 commits intoelastic:masterfrom
adriansr:fix-suricata-event-kind
Feb 5, 2019
Merged

Suricata: Rename event.type to suricata.eve.event_type#10575
adriansr merged 4 commits intoelastic:masterfrom
adriansr:fix-suricata-event-kind

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

@adriansr adriansr commented Feb 5, 2019

event.type is reserved for future use in ECS. Fallback to the original Suricata field.

This undoes a previous aliasing to event.type in 7.0.

`event.type` is reserved for future use in ECS. Fallback to the original
Suricata field.

This undoes a previous aliasing to `event.type` in 7.0.
@adriansr adriansr requested review from andrewkroh and ruflin February 5, 2019 16:40
@adriansr adriansr requested review from a team as code owners February 5, 2019 16:40
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/secops

Copy link
Copy Markdown
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adriansr adriansr force-pushed the fix-suricata-event-kind branch from 743d38a to ad2efcf Compare February 5, 2019 16:51
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in a static event.kind: event too.

@adriansr adriansr merged commit 392f7f2 into elastic:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants