[Metricbeat] Align rabbitmq with ECS and have module fields#10563
Merged
ruflin merged 5 commits intoelastic:masterfrom Feb 5, 2019
Merged
[Metricbeat] Align rabbitmq with ECS and have module fields#10563ruflin merged 5 commits intoelastic:masterfrom
ruflin merged 5 commits intoelastic:masterfrom
Conversation
webmat
reviewed
Feb 5, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Nothing major. Perhaps you had good reasons, but here are my concerns:
- A field def is deleted instead of being aliased to rabbitmq.node.name
- Why delete assertions, shouldn't you instead adjust the field names in the assertion? Even if redundant field names, different code paths set these values.
webmat
approved these changes
Feb 5, 2019
Contributor
|
@ruflin Oh, forgot: ecs-migration.yml for that missing alias |
Contributor
Author
|
@webmat Seems like it's already there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.