[Metricbeat] Update RabbitMQ module to use reporter interface#10560
Merged
ruflin merged 2 commits intoelastic:masterfrom Feb 5, 2019
Merged
[Metricbeat] Update RabbitMQ module to use reporter interface#10560ruflin merged 2 commits intoelastic:masterfrom
ruflin merged 2 commits intoelastic:masterfrom
Conversation
Contributor
ruflin
commented
Feb 5, 2019
- The integration tests for connection, exchange and queue were removed as they only contained data generation and did not really work
- The data generation in the rabbitmq module is the way I would hope we do it in other modules in the future as it's static
- Update data.json files
* The integration tests for connection, exchange and queue were removed as they only contained data generation and did not really work * The data generation in the rabbitmq module is the way I would hope we do it in other modules in the future as it's static * Update data.json files
jsoriano
approved these changes
Feb 5, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.