Add username password back from es to kibana config#10553
Merged
kaiyan-sheng merged 1 commit intoelastic:masterfrom Feb 5, 2019
kaiyan-sheng:kibana_config
Merged
Add username password back from es to kibana config#10553kaiyan-sheng merged 1 commit intoelastic:masterfrom kaiyan-sheng:kibana_config
kaiyan-sheng merged 1 commit intoelastic:masterfrom
kaiyan-sheng:kibana_config
Conversation
ruflin
approved these changes
Feb 5, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM
Not for this PR but would probably be good that we have some tests for this.
urso
reviewed
Feb 5, 2019
| if !kibanaConfig.HasField("password") && password != "" { | ||
| kibanaConfig.SetString("password", -1, password) | ||
| } | ||
| } |
There was a problem hiding this comment.
I know this is some old code re-introduced. But in general: We should not use SetX on globally shared configuration objects. Instead of passing through *common.Config, as is done here, we should strive for concrete types and unpack as early as possible.
Contributor
There was a problem hiding this comment.
@urso Would it be ok for you to get this in as is for FF and we open an issue to clean this up?
Contributor
Author
This was referenced Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10451 seems to be the reason why dashboard failed to load under security: #10513 @andrewkroh Thank you for your help!