[Metricbeat] Move mongodb.status metricset to ECS#10368
Merged
ruflin merged 5 commits intoelastic:masterfrom Jan 29, 2019
Merged
[Metricbeat] Move mongodb.status metricset to ECS#10368ruflin merged 5 commits intoelastic:masterfrom
ruflin merged 5 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@webmat For now I didn't touch anything around process. |
sayden
approved these changes
Jan 28, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
Code looks good. I'm just wondering why it has detected a full change in data.json when it has actually only removed 2 lines (it passed from 209 to 207 lines). Also the timestamp looks unmodified. Is it ok?
Contributor
Author
|
webmat
reviewed
Jan 28, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Seems like some copy/pasta lead to the mongodb module trying to grab stuff from haproxy.* in the events. This probably has to change, right? ;-)
I think keeping the .process custom field is superfluous (more on that below), but I don't feel too strongly about it either way.
So apart from the first point, this looks good 👍
Only field changed for now is service.version. The metricset was also changed to use the reporter interface.
2fad96c to
c2e3997
Compare
Contributor
Author
|
Ready for another round of reviews. |
jsoriano
reviewed
Jan 29, 2019
jsoriano
approved these changes
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only field changed for now is service.version.
The metricset was also changed to use the reporter interface.