[Metricbeat] Rename http.request.body to http.request.body.content for ECS#10315
Merged
ruflin merged 4 commits intoelastic:masterfrom Jan 28, 2019
Merged
[Metricbeat] Rename http.request.body to http.request.body.content for ECS#10315ruflin merged 4 commits intoelastic:masterfrom
ruflin merged 4 commits intoelastic:masterfrom
Conversation
webmat
reviewed
Jan 24, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Looking good so far.
- One thing to adjust in ecs-migration.
- Also, I assume the actual fields.yml changes are coming? ;-)
dev-tools/ecs-migration.yml
Outdated
Contributor
There was a problem hiding this comment.
Can't be aliased unfortunately, as the new field is moving directly under it. This means http.request.body can't be of type alias, since it has .content nested under it.
f35fe4c to
b13d2bd
Compare
ruflin
commented
Jan 25, 2019
Contributor
Author
There was a problem hiding this comment.
This was removed because body.content is already in ECS
webmat
approved these changes
Jan 25, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Looking good, once the changelog gets the PR ID :-)
b13d2bd to
338d5d5
Compare
…r ECS The header fields were not touched in this change as not defined yet in ECS.
338d5d5 to
a883b67
Compare
kaiyan-sheng
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header fields were not touched in this change as not defined yet in ECS.