[Metricbeat] Copy k8s.event.message to message field for ECS#10284
Merged
ruflin merged 1 commit intoelastic:masterfrom Jan 23, 2019
Merged
[Metricbeat] Copy k8s.event.message to message field for ECS#10284ruflin merged 1 commit intoelastic:masterfrom
ruflin merged 1 commit intoelastic:masterfrom
Conversation
The field is not renamed as inside k8s it is used as keyword field and not as text. To keep this the field is copied over.
webmat
reviewed
Jan 23, 2019
| type: keyword | ||
| description: > | ||
| Message recorded for the given event | ||
| copy_to: message |
Contributor
There was a problem hiding this comment.
Why copy_to and not renaming the field?
Can these messages wrap another message from a container?
Contributor
Author
There was a problem hiding this comment.
The part I was concerned here is that it's keyword and might be also used in other ways. @exekias will know more here.
Contributor
There was a problem hiding this comment.
Ah right. Hence why I thought we should make everything keyword (and add mf message.text) ;-)
But this works
Contributor
Author
There was a problem hiding this comment.
Still think message as text was a good call ;-)
webmat
approved these changes
Jan 23, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
LGTM, agree with copy_to for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field is not renamed as inside k8s it is used as keyword field and not as text. To keep this the field is copied over.