Update NFS protocol to use ECS fields#10153
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Jan 18, 2019
Merged
Conversation
That dashboard was updated too. Here's a summary of what fields changed. Part of elastic#7968 Changed - rpc.call_size -> source.bytes - rpc.reply_size -> destination.bytes - rpc.time -> event.duration (unit are now nanoseconds) Added - destination - event.dataset = nfs - event.end - event.start - network.bytes - network.community_id - network.protocol = nfsv4 or nfsv3 - network.transport = tcp - network.type - source - source.domain - set to the caller's RPC machine name Removed - rpc.time_str - Kibana should provide a human-readable form for event.duration rather than each event supplying a string. Unchanged Packetbeat Fields - status - type = nfs (we might remove this since we have event.dataset)
68c9678 to
a3603bf
Compare
webmat
approved these changes
Jan 18, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Nit on why rpc.time isn't an alias. Since the scale is different, I argue it shouldn't become one later, even when all protocols are migrated.
Otherwise LGTM
| alias: false | ||
| comment: > | ||
| Cannot add alias at this time because the field is used by MongoDB which | ||
| has not been updated yet. |
Contributor
There was a problem hiding this comment.
Also because the scale is different, right? Visually in Kibana it should be fine, but it may lead to surprises if people use this field otherwise, like for thresholds. E.g. rpc.time > 1000. After the move to nanoseconds, this would match pretty much everything ;-)
Contributor
There was a problem hiding this comment.
The two below I agree can be turned into actual aliases later, however.
Member
Author
There was a problem hiding this comment.
Good point. The same applies to responsetime and event.duration since they are different units.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That dashboard was updated too.
Here's a summary of what fields changed.
Part of #7968
Changed
Added
Removed
Unchanged Packetbeat Fields