Update pgSQL protocol to use ECS fields#10147
Merged
andrewkroh merged 4 commits intoelastic:masterfrom Jan 24, 2019
Merged
Conversation
andrewkroh
commented
Jan 17, 2019
webmat
reviewed
Jan 18, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Left a few comments. Looking pretty good
Contributor
|
If I understand correctly, all changed fields are Pb-wide, so the ecs-migration.yml and field aliases will come at the end. That's good. Is that also how you're approaching the changelog for the breaking changes? This PR could have an "Added" changelog, though. |
Contributor
|
Never mind the comment about the changelog above. Not sure how I missed it when reviewing. |
8d4f118 to
1ef4807
Compare
That dashboard was updated too. Here's a summary of what fields changed. Part of elastic#7968 Changed - bytes_in -> source.bytes - bytes_out -> destination.bytes - notes -> error.message - responsetime -> event.duration (unit are now nanoseconds) Added - destination - event.dataset = pgsql - event.end - event.start - network.bytes - network.community_id - network.protocol = pgsql - network.transport = tcp - network.type - source Removed - pgsql.iserror - It was a boolean that reflected the same information as `status` which uses OK or Error. - pgsql.query - It was in fields.yml but not in the code. Unchanged Packetbeat Fields - method - query - status - type = pgsql (we might remove this since we have event.dataset)
3c86a18 to
868448a
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That dashboard was updated too.
Here's a summary of what fields changed.
Part of #7968
Changed
Added
Removed
statuswhich uses OK or Error.Unchanged Packetbeat Fields