Convert Filebeat haproxy.log to ECS even more!#10143
Merged
webmat merged 9 commits intoelastic:masterfrom Jan 17, 2019
Merged
Conversation
2ead1e3 to
b12abe2
Compare
ruflin
approved these changes
Jan 17, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the follow up cleanup.
filebeat/module/haproxy/log/test/httplog-no-headers.log-expected.json
Outdated
Show resolved
Hide resolved
added 8 commits
January 17, 2019 15:16
b12abe2 to
013c3d5
Compare
Contributor
Author
|
Spotted one detail prior to merging. Will merge when CI is green. |
Contributor
Author
|
CI test failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module was migrated prior to ECS 1.0.0-beta2, and therefore has a few things left to migrate.
Caveats
haproxy.bytes_read: Both the TCP logs and the HTTP logs use the field. So it's copied tohttp.response.byteswhen parsing HTTP logs, but not when parsing TCP logs.Renames
Different scale, original fields still present:
Note that
haproxy.client.ipis migrated in #10141TODO
migration: true