Update AMQP protocol to use ECS fields#10090
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Jan 16, 2019
Merged
Conversation
There are no dashboards to update. Here's a summary of what fields changed. Part of elastic#7968 Changed - bytes_in -> source.bytes - bytes_out -> destination.bytes - responsetime -> event.duration - notes -> error.message Added - client - server - event.dataset = amqp - event.start - event.end - network.bytes - network.community_id - network.protocol = dhcpv4 - network.transport = tcp - network.type Unchanged Packetbeat Fields - method - status - type = amqp (we might remove this since we have event.dataset) - request - response
9d89487 to
920478c
Compare
ruflin
approved these changes
Jan 16, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM
I assume here it's the same that all these fields are already in the migration yml.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no dashboards to update.
Here's a summary of what fields changed.
Part of #7968
Changed
Added
Unchanged Packetbeat Fields