Introduce alias support for index pattern#10075
Conversation
libbeat/common/field.go
Outdated
There was a problem hiding this comment.
exported method Fields.GetField should have comment or be unexported
libbeat/kibana/testdata/beat-6.json
Outdated
There was a problem hiding this comment.
@simitt Is there a good way to generate these files? I'm fighting to get the tests passing.
libbeat/kibana/testdata/beat-6.json
Outdated
There was a problem hiding this comment.
@simitt Is there a good way to generate these files? I'm fighting to get the tests passing.
libbeat/kibana/testdata/beat-6.json
Outdated
There was a problem hiding this comment.
This is the way I make it show up fieldsFormat: https://github.com/elastic/beats/pull/10075/files#diff-086ab841dd8317d2aeec5107211984c2R87 Running it against Kibana this trick seems to work. My problem is with the tests and fieldFormatMap
There was a problem hiding this comment.
Actually I don't recall a good way for creating the tests automatically.
|
I pushed a commit that I think fixes this, please take a look, I had to change part of the test data as I think something was missing |
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Unfortunately I can't approve it with a checkbox as Github tells me it's my own :-) We should probably also add a changelog entry?
libbeat/kibana/fields_transformer.go
Outdated
There was a problem hiding this comment.
Almost forgot that part.
The goal of this PR is that in case an alias is detected in the fields.yml, for the index pattern the fields from the original are copied over.
58b0b63 to
e170ba6
Compare
The goal of this PR is that in case an alias is detected in the fields.yml, for the index pattern the fields from the original are copied over.