[Auditbeat] Cherry-pick #10018 to 6.x: Change module configuration from "metricsets" to "datasets"#10051
Merged
cwurm merged 1 commit intoelastic:6.xfrom Jan 15, 2019
Merged
Conversation
…s" (elastic#10018) Changes the Auditbeat system module configuration to use "datasets" rather than "metricsets" to configure its sub-modules: ``` - module: system datasets: - host - process [...] ``` (cherry picked from commit e42ccb4)
houndci-bot
reviewed
Jan 14, 2019
Contributor
|
Pinging @elastic/secops |
tsg
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10018 to 6.x branch. Original message:
This changes the Auditbeat system module configuration to use "datasets" rather than "metricsets" to configure its sub-modules:
It simply overwrites the
MetricSetsfield in the default Metricbeat configuration with the value of thedatasetsconfiguration.@andrewkroh We talked about the difficulty of making changes to
go-ucfgor to the Metricbeat code. Turns out there is no need to change anything undermetricbeat/, so I think this might be ok? What do you think? I think in the long term we might still want to change to a fileset-like configuration, but for now this would avoid having a mix of "dataset" and "metricset" in anything user-facing, i.e. documentation or configuration.Follow-up: