-
Notifications
You must be signed in to change notification settings - Fork 5k
Metricbeat SQL Helper #9416
Copy link
Copy link
Closed
Labels
MetricbeatMetricbeatMetricbeatTeam:IntegrationsLabel for the Integrations teamLabel for the Integrations teamdiscussIssue needs further discussion.Issue needs further discussion.enhancementmodule
Metadata
Metadata
Assignees
Labels
MetricbeatMetricbeatMetricbeatTeam:IntegrationsLabel for the Integrations teamLabel for the Integrations teamdiscussIssue needs further discussion.Issue needs further discussion.enhancementmodule
Type
Fields
Give feedbackNo fields configured for issues without a type.
Some of our modules for SQL databases rely on plain SQL queries to fetch metrics information. Golang has the
sqldriver which should help in creating a SQL helper that just accepts queries and parses information for metricbeat.There's a work already done in MS SQL metricbeat module that uses a similar approach, the first idea is to abstract this code from MSSQL module.
We have seen that if this is develop, the
vendorfolder in MySQL module should be removed https://github.com/elastic/beats/tree/master/metricbeat/module/mysql/vendorWe still need to discuss if this helper is going to be released only as helper of other modules or with a sql-module too but in any case, if a module if going to rely 90% of its functionality on this helper, it needs to follow a common modula GA checklist.
SQL Helper release checklist
This checklist is intended for Devs which create or update a module to make sure modules are consistent.
Modules
For a metricset to go GA, the following criterias should be met:
Metricbeat module
data.jsonexists and an automated way to generate it exists (go test -data)For this particular Metricbeat Helper